Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose BIOS configuration in Server type #89

Merged
merged 10 commits into from
Aug 5, 2024
Merged

Expose BIOS configuration in Server type #89

merged 10 commits into from
Aug 5, 2024

Conversation

stefanhipfel
Copy link
Contributor

@stefanhipfel stefanhipfel commented Jul 24, 2024 •
edited by afritzler
Loading

Proposed changes

  • Add BIOS configuration to Server type
  • Implement ServerReconciler logic to set BIOS settings
  • Improve boot order handling in Server type

Fixes #85

@stefanhipfel stefanhipfel linked an issue Jul 24, 2024 that may be closed by this pull request
Expose BIOS configuration in Server type #85
Closed
@stefanhipfel stefanhipfel requested review from 5kt and gehoern July 24, 2024 14:35
@afritzler afritzler added the enhancement New feature or request label Jul 25, 2024
afritzler
afritzler requested changes Jul 25, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanhipfel for your PR. Please find my comments below. Could you also rebase your PR branch please.

bmc/redfish.go Outdated Show resolved Hide resolved
api/v1alpha1/server_types.go Outdated Show resolved Hide resolved
bmc/redfish_local.go Outdated Show resolved Hide resolved
bmc/redfish.go Outdated Show resolved Hide resolved
@afritzler afritzler changed the title Expose BIOS configuration in Server type Expose BIOS configuration in Server type Jul 25, 2024
@stefanhipfel stefanhipfel marked this pull request as draft July 25, 2024 08:12
@github-actions github-actions bot added size/XL and removed size/L labels Jul 26, 2024
@stefanhipfel stefanhipfel marked this pull request as ready for review July 31, 2024 07:16
afritzler
afritzler requested changes Jul 31, 2024
View reviewed changes
Copy link
Member

@afritzler afritzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues. Could you also run make docs once documentation has been added to the newly added fields?

api/v1alpha1/server_types.go Outdated Show resolved Hide resolved
api/v1alpha1/server_types.go Outdated Show resolved Hide resolved
api/v1alpha1/server_types.go Show resolved Hide resolved
internal/controller/server_controller.go Show resolved Hide resolved
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 31, 2024
@hardikdr hardikdr merged commit 7983c69 into main Aug 5, 2024
8 checks passed
@hardikdr hardikdr deleted the bios_configuration branch August 5, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aobort aobort aobort left review comments

@hardikdr hardikdr hardikdr approved these changes

@afritzler afritzler afritzler approved these changes

@5kt 5kt Awaiting requested review from 5kt

@gehoern gehoern Awaiting requested review from gehoern

Assignees
No one assigned
Labels
api-change documentation Improvements or additions to documentation enhancement New feature or request size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose BIOS configuration in Server type
4 participants
@stefanhipfel @afritzler @hardikdr @aobort